refactor: extract formatting options into DisplayIteratorOptions - #13
Merged
Merged
Conversation
xp-trumpet
reviewed
Mar 30, 2026
xp-trumpet
left a comment
xp-trumpet
left a comment
There was a problem hiding this comment.
@xp-trumpet reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on drmingdrmer).
drmingdrmer
force-pushed
the
011-display-braces
branch
2 times, most recently
from
March 30, 2026 13:36
dccc9c3 to
b09099c
Compare
xp-trumpet
reviewed
Mar 30, 2026
xp-trumpet
left a comment
xp-trumpet
left a comment
There was a problem hiding this comment.
@xp-trumpet reviewed 4 files and all commit messages.
Reviewable status:
Move the formatting fields (limit, separator, braces, ellipsis, element prefix/suffix, show_count) out of `DisplayIntoIter` into a dedicated `DisplayIteratorOptions` struct. This separates the data source concern (what to iterate) from the presentation concern (how to format), making the options reusable and the iterator struct smaller.
drmingdrmer
force-pushed
the
011-display-braces
branch
from
March 30, 2026 13:40
b09099c to
f022c68
Compare
xp-trumpet
reviewed
Mar 30, 2026
xp-trumpet
left a comment
xp-trumpet
left a comment
There was a problem hiding this comment.
@xp-trumpet reviewed 1 file and all commit messages.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
refactor: extract formatting options into
DisplayIteratorOptionsMove the formatting fields (limit, separator, braces, ellipsis, element
prefix/suffix, show_count) out of
DisplayIntoIterinto a dedicatedDisplayIteratorOptionsstruct. This separates the data source concern(what to iterate) from the presentation concern (how to format), making
the options reusable and the iterator struct smaller.